Skip to content

client/RedisSocket: handle *all* error emits #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

client/RedisSocket: handle *all* error emits #2054

wants to merge 1 commit into from

Conversation

MCApollo
Copy link

Description

Describe your pull request here

Attempts to fix #1993

    NodeJS will throw a error event (from EventEmitter) if there's no handler.
    Handle the error at all times to prevent crashing the process.

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@MCApollo
client/RedisSocket: handle *all* error emits
a2d85fd 
    NodeJS will throw a error event (from EventEmitter) if there's no handler.
    Handle the error at all times to prevent crashing the process.
@MCApollo MCApollo closed this Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

socket.reconnectStrategy short circuits if no error listener is added to redis client.
1 participant
@MCApollo